From 1cedc0765dacf00f0a3eee88c918e87cdeb799a4 Mon Sep 17 00:00:00 2001
From: Eric Coissac <eric.coissac@metabarcoding.org>
Date: Wed, 7 Jun 2023 17:54:02 +0200
Subject: [PATCH] update release note and the install script

Former-commit-id: 11db481e26f3f5099b9ea8b2d66658d47f2992b1
---
 Release-notes.md    | 13 +++++++++++++
 install_obitools.sh |  8 ++++----
 2 files changed, 17 insertions(+), 4 deletions(-)

diff --git a/Release-notes.md b/Release-notes.md
index e4560b6..fd33d93 100644
--- a/Release-notes.md
+++ b/Release-notes.md
@@ -2,11 +2,24 @@
 
 ## Latest changes
 
+### Bugs
+
+- Patch a bug in the install script for correctly follow download redirection.
+
 ### Enhancement
 
 - Comparison algorithms in `obitag` and `obirefidx` take more advantage of the data structure to limit the number of alignments
   actually computed. This increase a bit the speed of both the software. `obirefidx` is nevertheless still too slow
   compared to my expectation.
+
+### New feature
+
+- In `obiannotate` adds the **--set-identifier** option to edit the sequence identifier
+- In `obitag` adds the **--save-db** option allowing at the end of the run of `obitag` to save a
+  modified version of the reference database containing the computed index. This allows next
+  time using this partially indexed reference library to accelerate the taxonomic annotations. 
+- Adding of the function `gsub` to the expression language for substituting string pattern.
+
 ## May 2nd, 2023. Release 4.0.3
 
 ### New features
diff --git a/install_obitools.sh b/install_obitools.sh
index e58a948..5f31fde 100755
--- a/install_obitools.sh
+++ b/install_obitools.sh
@@ -63,7 +63,7 @@ mkdir -p "${INSTALL_DIR}/bin" 2> /dev/null \
   || (echo "Please enter your password for installing obitools in ${INSTALL_DIR}"  1>&2
       sudo mkdir -p "${INSTALL_DIR}/bin")
 
-if [[ ! "${INSTALL_DIR}/bin" || ! -d "${INSTALL_DIR}/bin" ]]; then
+if [[ ! -d "${INSTALL_DIR}/bin" ]]; then
   echo "Could not create ${INSTALL_DIR}/bin directory for installing obitools"  1>&2
   exit 1
 fi
@@ -109,7 +109,7 @@ export PATH
 curl -L "$OBIURL4" \
     | tar zxf - 
 
-cd obitools4-master
+cd obitools4-master || exit
 
 if [[ -z "$OBITOOLS_PREFIX" ]] ; then
   make
@@ -121,7 +121,7 @@ fi
    || (echo "Please enter your password for installing obitools in ${INSTALL_DIR}" 
        sudo cp build/* "${INSTALL_DIR}/bin")
 
-popd
+popd || exit
 
-# rm -rf "$WORK_DIR"
+rm -rf "$WORK_DIR"