Doc change

Former-commit-id: 5cd4547147804f887ad699d4886702545584ba32

pkg/obiapat/pattern.go

@@ -53,11 +53,8 @@ var NilApatPattern = ApatPattern{nil}
 // type.
 var NilApatSequence = ApatSequence{nil}
 
-// MakeApatPattern builds a new ApatPattern.
+// MakeApatPattern creates an ApatPattern object based on the given pattern, error maximum and allowsIndel flag.
-// The created object wrap a C allocated structure.
+//
-// Do not forget to free it when it is no more needed
-// to forbid memory leaks using the Free methode of the
-// ApatPattern.
 // The pattern is a short DNA sequence (up to 64 symboles).
 // Ambiguities can be represented or using UIPAC symboles,
 // or using the [...] classical in regular pattern grammar.
@@ -69,6 +66,13 @@ var NilApatSequence = ApatSequence{nil}
 // the errormax parameter. Some positions can be marked as not
 // allowed for mismatches. They have to be signaled using a '#'
 // sign after the corresponding nucleotide.
+//
+// Parameters:
+// pattern: The input pattern string.
+// errormax: The maximum number of errors allowed.
+// allowsIndel: A flag indicating whether indels are allowed or not.
+//
+// Returns an ApatPattern object and an error.
 func MakeApatPattern(pattern string, errormax int, allowsIndel bool) (ApatPattern, error) {
 	cpattern := C.CString(pattern)
 	defer C.free(unsafe.Pointer(cpattern))
@@ -90,7 +94,6 @@ func MakeApatPattern(pattern string, errormax int, allowsIndel bool) (ApatPatter
 		return NilApatPattern, errors.New(message)
 	}
 
-
 	ap := _ApatPattern{apc, pattern}
 
 	runtime.SetFinalizer(&ap, func(p *_ApatPattern) {
@@ -185,7 +188,6 @@ func MakeApatSequence(sequence *obiseq.BioSequence, circular bool, recycle ...Ap
 		out = nil
 	}
 
-
 	// copy the data into the buffer, by converting it to a Go array
 	p := unsafe.Pointer(unsafe.SliceData(sequence.Sequence()))
 	pseqc := C.new_apatseq((*C.char)(p), C.int32_t(ic), C.int32_t(seqlen),
@@ -210,9 +212,9 @@ func MakeApatSequence(sequence *obiseq.BioSequence, circular bool, recycle ...Ap
 		runtime.SetFinalizer(&seq, func(apat_p *_ApatSequence) {
 			var errno C.int32_t
 			var errmsg *C.char
-			log.Debugf("Finaliser called on %p\n", apat_p.pointer)
 
 			if apat_p != nil && apat_p.pointer != nil {
+				log.Debugf("Finaliser called on %p\n", apat_p.pointer)
 				C.delete_apatseq(apat_p.pointer, &errno, &errmsg)
 			}
 		})
@@ -334,7 +336,6 @@ func (pattern ApatPattern) BestMatch(sequence ApatSequence, begin, length int) (
 	cpattern := (*[1 << 30]byte)(unsafe.Pointer(pattern.pointer.pointer.cpat))
 	frg := sequence.pointer.reference.Sequence()[start:end]
 
-
 	log.Debugln(
 		string(frg),
 		string((*cpattern)[0:int(pattern.pointer.pointer.patlen)]),

pkg/obiapat/pattern_test.go

@@ -0,0 +1,43 @@
+package obiapat
+
+import (
+	"testing"
+)
+
+func TestMakeApatPattern(t *testing.T) {
+	// Test case 1: pattern with no errors allowed
+	pattern1 := "ACGT"
+	errormax1 := 0
+	allowsIndel1 := false
+	actual1, err1 := MakeApatPattern(pattern1, errormax1, allowsIndel1)
+	if err1 != nil {
+		t.Errorf("Error in test case 1: %v", err1)
+	}
+	if actual1.pointer == nil {
+		t.Errorf("Incorrect result in test case 1. Expected a non-nil ApatPattern pointer, but got nil")
+	}
+
+	// Test case 2: pattern with errors allowed and indels allowed
+	pattern2 := "A[T]C!GT"
+	errormax2 := 2
+	allowsIndel2 := true
+	actual2, err2 := MakeApatPattern(pattern2, errormax2, allowsIndel2)
+	if err2 != nil {
+		t.Errorf("Error in test case 2: %v", err2)
+	}
+	if actual2.pointer == nil {
+		t.Errorf("Incorrect result in test case 2. Expected a non-nil ApatPattern pointer, but got nil")
+	}
+
+	// Test case 3: pattern with errors allowed and indels not allowed
+	pattern3 := "A[T]C!GT"
+	errormax3 := 2
+	allowsIndel3 := false
+	actual3, err3 := MakeApatPattern(pattern3, errormax3, allowsIndel3)
+	if err3 != nil {
+		t.Errorf("Error in test case 3: %v", err3)
+	}
+	if actual3.pointer == nil {
+		t.Errorf("Incorrect result in test case 3. Expected a non-nil ApatPattern pointer, but got nil")
+	}
+}