refactor: remove unused dependencies and simplify logic

Remove obsolete dependencies across multiple crates to clean up the build graph and update `obikdump` to use `try_update`. Add dev-dependencies for tracing in `obiread` and clarify memoization logic in `obiksession`.

- Remove `obifastwrite`, `tracing`, `obidebruinj`, `obikentropy`, `obipipeline`, `obidex`, and `obiskbuilder` from `Cargo.lock`.
- Remove `obifastwrite` and `tracing` dependencies from `src/obidebruinj/Cargo.toml`.
- Update `dump` function in `src/obikdump/src/dump.rs` to use `try_update` instead of `fetch_update` for updating remaining counts.
- Remove `obitaxonomy`, `obidebruinj`, `obipipeline`, and `obikentropy` dependencies from `src/obikindex/Cargo.toml`.
- Remove `obiksession` dependency from `src/obikmer/Cargo.toml`.
- Remove `obiskbuilder` dependency from `src/obikphylo/Cargo.toml` and update `kodama` version to "0.3.0".
- Remove `bytes` dependency from `src/obikrope/Cargo.toml` and set `criterion2` version to "3" with `cargo_bench_support`.
- Add `tracing` and `tracing-subscriber` as dev-dependencies in `src/obiread/Cargo.toml`.
- Remove `lazy_static` dependency from `src/obiskbuilder/Cargo.toml` and add `obikseq` as a test-utils dev-dependency.
- Clarify `memo_key_from_debug` in `src/obiksession/src/memoize.rs` with comments explaining Debug-derived field usage.
This commit is contained in:
Eric Coissac committed 2026-11-19 07:07:16 +01:00
1 parent cbc344e4b4
commit 24291a4484
10 files changed
+9 -23

No files matched your search

-10
View File
@@ -1408,10 +1408,8 @@ version = "0.1.0"
dependencies = [
"crossbeam-channel",
"hashbrown 0.17.1",
"obifastwrite",
"obikseq",
"rayon",
"tracing",
]
[[package]]
@@ -1492,14 +1490,10 @@ dependencies = [
"ndarray",
"niffler",
"obicompactvec",
"obidebruinj",
"obikentropy",
"obikseq",
"obipipeline",
"obiread",
"obiskio",
"obisys",
"obitaxonomy",
"ptr_hash",
"rayon",
"serde",
@@ -1556,7 +1550,6 @@ dependencies = [
"obikrope",
"obikselect",
"obikseq",
"obiksession",
"obikstats",
"obipipeline",
"obiread",
@@ -1600,7 +1593,6 @@ dependencies = [
"obikseq",
"obipipeline",
"obiread",
"obiskbuilder",
"obiskio",
"obisys",
"petgraph",
@@ -1646,7 +1638,6 @@ dependencies = [
name = "obikrope"
version = "0.1.0"
dependencies = [
"bytes",
"criterion2",
]
@@ -1724,7 +1715,6 @@ name = "obiskbuilder"
version = "0.1.0"
dependencies = [
"criterion2",
"lazy_static",
"obikentropy",
"obikrope",
"obikseq",
-2
View File
@@ -5,11 +5,9 @@ edition = "2021"
[dependencies]
obikseq = { path = "../obikseq" }
obifastwrite = { path = "../obifastwrite" }
hashbrown = { version = "0.17", features = ["rayon"] }
rayon = "1"
crossbeam-channel = "0.5"
tracing = "0.1"
[features]
test-utils = []
+1 -1
View File
@@ -81,7 +81,7 @@ impl IndexDump for Arc<KmerIndex> {
if remaining.load(Ordering::Relaxed) == 0 { return Ok(vec![]); }
let mut buf = Vec::<u8>::new();
let try_write = |buf: &mut Vec<u8>, row: &[u32], prefix: &str| -> bool {
match remaining.fetch_update(Ordering::SeqCst, Ordering::SeqCst, |cur| {
match remaining.try_update(Ordering::SeqCst, Ordering::SeqCst, |cur| {
if cur > 0 { Some(cur - 1) } else { None }
}) {
Err(_) => false,
-4
View File
@@ -5,13 +5,9 @@ edition = "2024"
[dependencies]
obikseq = { path = "../obikseq" }
obitaxonomy = { path = "../obitaxonomy" }
obiskio = { path = "../obiskio" }
obisys = { path = "../obisys", default-features = false }
obicompactvec = { path = "../obicompactvec" }
obidebruinj = { path = "../obidebruinj" }
obipipeline = { path = "../obipipeline" }
obikentropy = { path = "../obikentropy" }
cacheline-ef = "2.0"
epserde = "0.13"
ptr_hash = { version = "2.1", features = ["epserde"] }
-1
View File
@@ -24,7 +24,6 @@ obikstats = { path = "../obikstats" }
obikquery = { path = "../obikquery" }
obikidxcache = { path = "../obikidxcache" }
obikphylo = { path = "../obikphylo" }
obiksession = { path = "../obiksession" }
obikrope = { path = "../obikrope" }
obifastwrite = { path = "../obifastwrite" }
obiskbuilder = { path = "../obiskbuilder" }
-1
View File
@@ -10,7 +10,6 @@ obiskio = { path = "../obiskio" }
obisys = { path = "../obisys", default-features = false }
obicompactvec = { path = "../obicompactvec" }
obikidxcache = { path = "../obikidxcache" }
obiskbuilder = { path = "../obiskbuilder" }
obipipeline = { path = "../obipipeline" }
kodama = "0.3.0"
memmap2 = "0.9"
-1
View File
@@ -7,4 +7,3 @@ edition = "2024"
criterion2 = { version = "3", features = ["cargo_bench_support"] }
[dependencies]
bytes = "1.11.1"
+3
View File
@@ -342,6 +342,9 @@ mod tests {
#[test]
fn memo_key_from_debug() {
// Fields are only read through `Debug`, which is what the memo key
// is derived from — and what dead-code analysis ignores.
#[allow(dead_code)]
#[derive(Debug)]
struct Args {
x: u64,
+5 -2
View File
@@ -13,7 +13,10 @@ niffler = { version = "3", default-features = false, features = ["gz", "bz2",
bzip2 = "0.6"
liblzma = { version = "0.4", features = ["static"] }
ureq = "3"
tracing = "0.1.44"
tracing-subscriber = { version = "0.3.23", features = ["fmt", "env-filter"] }
infer = "0.22.0"
regex = "1"
[dev-dependencies]
# Used by examples/expand_path.rs only.
tracing = "0.1.44"
tracing-subscriber = { version = "0.3.23", features = ["fmt", "env-filter"] }
-1
View File
@@ -8,7 +8,6 @@ obikseq = { path = "../obikseq" }
obikrope = { path = "../obikrope" }
obiread = { path = "../obiread" }
obikentropy = { path = "../obikentropy" }
lazy_static = "1.5.0"
[dev-dependencies]
obikseq = { path = "../obikseq", features = ["test-utils"] }